git / purple-line

Closed
Issue #1 · created by daktak 2015-07-10 03:42:55 UTC · 2015-07-13 06:23:53 UTC

Crash on loading conversation history when message contains game (pokopoko) message

temporary fix by try catching history (line 580)

if (recent_msgs.size()) { try { purple_conversation_write( ... } catch (...) {} } else { if (requested) {

3 participants

Link here
Saket Srivastava @sakbhav 2015-07-10 04:39:48 UTC
Crash also occurs when conversation history contains free voice call
Write

Preview

Crash also occurs when conversation history contains free voice call Edit in fullscreen

Comments are parsed with GitLab Flavored Markdown

Attach files by dragging & dropping or selecting them.

Cancel
Link here
Matti Virkkunen @mvirkkunen 2015-07-10 08:13:42 UTC
mentioned in commit 476ad038987b41e27920578741eef2098ac7306e
Write

Preview

mentioned in commit 476ad038987b41e27920578741eef2098ac7306e Edit in fullscreen

Comments are parsed with GitLab Flavored Markdown

Attach files by dragging & dropping or selecting them.

Cancel
Link here
Matti Virkkunen @mvirkkunen 2015-07-10 08:16:13 UTC
I've committed a fix for unknown message types and verified that it works at least when you have a voice call in your history.

@daktak I don't have any games installed so can you check if the game message still crashes it?
Write

Preview

I've committed a fix for unknown message types and verified that it works at least when you have a voice call in your history. @daktak I don't have any games installed so can you check if the game message still crashes it? Edit in fullscreen

Comments are parsed with GitLab Flavored Markdown

Attach files by dragging & dropping or selecting them.

Cancel
Link here
Saket Srivastava @sakbhav 2015-07-10 08:49:34 UTC
commit 476ad038 fixed the voice call issue
Write

Preview

commit 476ad038 fixed the voice call issue Edit in fullscreen

Comments are parsed with GitLab Flavored Markdown

Attach files by dragging & dropping or selecting them.

Cancel
Link here
daktak @daktak 2015-07-13 06:23:48 UTC
Yep this resolves the issue

[Unimplemented message type: LINK]
Write

Preview

Yep this resolves the issue [Unimplemented message type: LINK] Edit in fullscreen

Comments are parsed with GitLab Flavored Markdown

Attach files by dragging & dropping or selecting them.

Cancel
Link here
daktak @daktak 2015-07-13 06:23:53 UTC
Status changed to closed
Write

Preview

Status changed to closed Edit in fullscreen

Comments are parsed with GitLab Flavored Markdown

Attach files by dragging & dropping or selecting them.

Cancel

Closed Issue #1 · created by daktak 2015-07-10 03:42:55 UTC $('.note_created_ago').timeago().tooltip() · 2015-07-13 06:23:53 UTC $('.issue_edited_ago').timeago().tooltip()

Crash on loading conversation history when message contains game (pokopoko) message

Closed
Issue #1 · created by daktak 2015-07-10 03:42:55 UTC · 2015-07-13 06:23:53 UTC